Conversation
lwaekfjlk
requested changes
Nov 11, 2025
Member
|
Hi @andrewBatutin , sorry for the delayed review. I was a little bit busy during the weekends. The PR looks amazingly good. But there are still some details that need to be fixed. Could you take a look at those comments? |
lwaekfjlk
reviewed
Nov 11, 2025
Collaborator
Author
Hi i've fixed the comments |
lwaekfjlk
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🪙 BitMEX Crypto Trading System
New Features
Trading System
Crypto-specific metrics:
live_trade_bench/systems/bitmex_system.py:152-153- Funding rate fetchinglive_trade_bench/agents/bitmex_agent.py:55-58- Funding rate in LLM promptslive_trade_bench/systems/bitmex_system.py:157-165- Bid/ask depth calculationlive_trade_bench/fetchers/bitmex_fetcher.py- Order book API integrationlive_trade_bench/systems/bitmex_system.py:181- Open interest datalive_trade_bench/agents/bitmex_agent.py:55-58- Open interest displaylive_trade_bench/fetchers/bitmex_fetcher.py:199- Price history fetchinglive_trade_bench/systems/bitmex_system.py:145-150- Historical price integration🔧 Backend Infrastructure
Trading Cycles:
backend/app/main.py:265-275backend/app/main.py:269backend/app/main.py:305-311,backend/app/price_data.py:534-540
Data Pipelines:
live_trade_bench/fetchers/news_fetcher.py:167,live_trade_bench/systems/bitmex_system.py:229-252live_trade_bench/fetchers/reddit_fetcher.py,live_trade_bench/systems/bitmex_system.py:265-328backend/app/price_data.py:524-559,live_trade_bench/fetchers/bitmex_fetcher.pybackend/app/price_data.py:534-540API Endpoints:
backend/app/routers/news.py:13backend/app/routers/social.py:13🎨 Frontend Integration
UI Components:
🧪 Backtesting Enhancements
Updated
examples/backtest_demo.py:🔧 System Reliability